fix/hereNow response parsing when channel Occupancy count property omitted from the response.#273
Merged
Conversation
added 2 commits
May 29, 2026 13:38
…equested without uuid details to assign channel occupancy to totalOccupancy returned by server, add empty channel data structure when there are no occupancy data in the response
mohitpubnub
requested review from
Xavrax,
jakub-grzesiowski and
marcin-cebo
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
mohitpubnub
changed the title
…response parsing in various cases of HereNow responses
mohitpubnub
commented
May 29, 2026
| } | ||
|
|
||
| hereNowResult.Channels = new Dictionary<string, PNHereNowChannelData>(); | ||
| // This block handles the "compact" here_now response shape that the server returns |
Contributor
Author
There was a problem hiding this comment.
this is where different response shapes are being handled for hereNow
Contributor
Author
|
@pubnub-release-bot release as v8.2.1 |
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix:
hereNowwill return correctOccupancycount with single channel and uuid excluded case when channel Occupancy property value is omitted from the response for given single channel.Fixes issue of hereNow returning incorrect Occupancy when Occupancy count value is omitted from the response of single channel hereNow call.
fix:
HereNowomitting the channel entry for an empty channel when UUIDs are included; the channel is now always returned with occupancy 0 and an empty occupants list.fix for
HereNowomitting the channel entry for an empty channel when UUIDs are included